-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update eslint to 9.8.0 #54073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Jul 28, 2024
targos
approved these changes
Jul 28, 2024
MoLow
approved these changes
Jul 28, 2024
MoLow
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 28, 2024
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jul 30, 2024
Commit Queue failed- Loading data for nodejs/node/pull/54073 ✔ Done loading data for nodejs/node/pull/54073 ----------------------------------- PR info ------------------------------------ Title tools: update eslint to 9.8.0 (#54073) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-eslint -> nodejs:main Labels tools Commits 1 - tools: update eslint to 9.8.0 Committers 1 - Node.js GitHub Bot <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54073 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54073 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 28 Jul 2024 00:29:54 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54073#pullrequestreview-2203388104 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54073#pullrequestreview-2203392865 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54073#pullrequestreview-2203486033 ✘ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10154179492 |
Landed in 4d1cc76 |
Nahee-Park
pushed a commit
to Nahee-Park/node
that referenced
this pull request
Jul 30, 2024
PR-URL: nodejs#54073 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54073 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of eslint to 9.8.0.