Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: split up large test file #54014

Closed
wants to merge 3 commits into from
Closed

sqlite: split up large test file #54014

wants to merge 3 commits into from

Commits on Aug 7, 2024

  1. sqlite: ensure statement finalization on db close 

    This commit adds statement tracking to the DatabaseSync class.
When a database is closed manually or via garbage collection, it
will force all associated prepared statements to be finalized.
This should mitigate "zombie" connections which can introduce
test flakiness in the CI on Windows.
    @cjihrig
    cjihrig committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5ea5579 View commit details
    Browse the repository at this point in the history

  2. sqlite: split up large test file 

    The original test/parallel/test-sqlite.js test appears to time
out in the CI occasionally. This commit splits the test into
several smaller test files.

Fixes: nodejs#54006
    @cjihrig
    cjihrig committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7bf62d0 View commit details
    Browse the repository at this point in the history

  3. test: unmark test-sqlite as flaky

    @cjihrig
    cjihrig committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ee5b9c1 View commit details
    Browse the repository at this point in the history