test_runner: remove redundant bootstrap boolean #54013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
atlowChemi
approved these changes
Jul 24, 2024
anonrig
approved these changes
Jul 24, 2024
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
cjihrig
added
the
commit-queue-squash
The test runner bootstrap process awaits a Promise and then sets a boolean flag. This commit consolidates the Promise and boolean into a single value. This commit also ensures that the globalRoot test is always assigned in createTestTree() in order to better consolidate the CLI/run() and non-CLI configuration.
This reverts commit 383ec7f.
|
I've been trying to figure out how this seemingly very innocent change was introducing EPERM failures on Windows when trying to clean up the tmp directory. Then I saw the same failures in an unrelated CI run. So, I'm going to land this once I get a green CI. It looks like the flaky test in question was introduced in #53866 (cc @mcollina). Related to the EPERM issues - I only tried one run, but using |
MoLow
approved these changes
Jul 25, 2024
cjihrig
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54013 ✔ Done loading data for nodejs/node/pull/54013 ----------------------------------- PR info ------------------------------------ Title test_runner: remove redundant bootstrap boolean (#54013) Author Colin Ihrig <[email protected]> (@cjihrig) Branch cjihrig:bootstrap -> nodejs:main Labels author ready, commit-queue-squash, test_runner Commits 4 - test_runner: remove redundant bootstrap boolean - hmm - ugh - Revert "ugh" Committers 1 - cjihrig <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54013 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54013 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 24 Jul 2024 04:09:00 GMT ✔ Approvals: 3 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/54013#pullrequestreview-2195620030 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54013#pullrequestreview-2196305917 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54013#pullrequestreview-2200309148 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-07-25T22:32:06Z: https://ci.nodejs.org/job/node-test-pull-request/60631/ - Querying data for job/node-test-pull-request/60631/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10105569552 |
anonrig
approved these changes
Jul 26, 2024
|
@cjihrig this commit cannot land atm because GHA did not run for this. |
|
Green CI + 3 approvals, is this PR ready to land?
What is GHA? I tried to find it in glossary but not there yet 😄 edit: Oh is it Github Action? |
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 14e7eb3 |
targos
pushed a commit
that referenced
this pull request
Jul 28, 2024
The test runner bootstrap process awaits a Promise and then sets a boolean flag. This commit consolidates the Promise and boolean into a single value. This commit also ensures that the globalRoot test is always assigned in createTestTree() in order to better consolidate the CLI/run() and non-CLI configuration. PR-URL: #54013 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
The test runner bootstrap process awaits a Promise and then sets a boolean flag. This commit consolidates the Promise and boolean into a single value. This commit also ensures that the globalRoot test is always assigned in createTestTree() in order to better consolidate the CLI/run() and non-CLI configuration. PR-URL: #54013 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runner bootstrap process awaits a Promise and then sets a boolean flag. This commit consolidates the Promise and boolean into a single value. This commit also ensures that the globalRoot test is always assigned in createTestTree() in order to better consolidate the CLI/run() and non-CLI configuration.