Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix worker threadId/destination typo #53933

Merged
merged 1 commit into from
Aug 2, 2024
Merged

doc: fix worker threadId/destination typo #53933

merged 1 commit into from
Aug 2, 2024

Conversation

tlhunter
Copy link
Contributor

@tlhunter tlhunter commented Jul 18, 2024 •
edited
Loading

The function signature uses threadId instead of destination:

worker.postMessageToThread(threadId, value[, transferList][, timeout])

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jul 18, 2024
@tlhunter tlhunter force-pushed the tlhunter/worker-threadid-docs-typo branch from 701a240 to c280eed Compare July 18, 2024 21:21
@tlhunter tlhunter changed the title docs: fix worker threadId/destination typo doc: fix worker threadId/destination typo Jul 18, 2024
@jakecastelli jakecastelli added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 13ca021 into nodejs:main Aug 2, 2024
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 13ca021

@tlhunter tlhunter deleted the tlhunter/worker-threadid-docs-typo branch August 2, 2024 13:40
targos pushed a commit that referenced this pull request Aug 14, 2024
@tlhunter @targos
doc: fix worker threadId/destination typo
1cafefd 
PR-URL: #53933
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@aymen94 aymen94 aymen94 approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tlhunter @nodejs-github-bot @jasnell @lpinca @aymen94 @jakecastelli @targos