Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: avoid compiling with VS v17.10 #53863

Merged
merged 2 commits into from
Jul 25, 2024
Merged

build: avoid compiling with VS v17.10 #53863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26a74ed
build: avoid compiling with VS v17.10
huseyinacacak-janea Jul 16, 2024
48ec713
Update vcbuild.bat
huseyinacacak-janea Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,14 @@ goto exit

:msbuild-found

@rem Visual Studio v17.10 has a bug that causes the build to fail.
@rem Check if the version is v17.10 and exit if it is.
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
if %errorlevel% neq 1 (
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
goto exit
)

@rem check if the clang-cl build is requested
if not defined clang_cl goto clang-skip
@rem x64 is hard coded as it is used for both cross and native compilation.
Expand Down
Loading