Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: throw TypeError when criteria fulfilled in getIterator #53825

Merged
merged 1 commit into from
Aug 1, 2024
Merged

stream: throw TypeError when criteria fulfilled in getIterator #53825

merged 1 commit into from
Aug 1, 2024

Conversation

jakecastelli
Copy link
Contributor

@jakecastelli jakecastelli commented Jul 12, 2024 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Jul 12, 2024
@jakecastelli jakecastelli changed the title webstream: throw TypeError when criteria fulfilled in getIterator stream: throw TypeError when criteria fulfilled in getIterator Jul 12, 2024
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60757/

@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60774/

@jakecastelli jakecastelli added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit 1fd170a into nodejs:main Aug 1, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1fd170a

targos pushed a commit that referenced this pull request Aug 14, 2024
@jakecastelli @targos
stream: throw TypeError when criteria fulfilled in getIterator
2a6a12e 
PR-URL: #53825
Fixes: #53819
Refs: #53819
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadableStream.from({}) returns confusing error
5 participants
@jakecastelli @nodejs-github-bot @jasnell @aduh95 @debadree25