doc: exclude voting and regular TSC from spotlight

[mhdawson]

There were some discussion in slack and thought a PR would be a good way to close on the discusion.

[nodejs-github-bot]

Review requested:

• @nodejs/tsc

[MoLow]

LGTM

[anonrig]

There were some discussion in slack and thought a PR would be a good way to close on the discusion.

What's the reasoning for removing TSC members for the spotlight? I'm not actively following Slack and for historical reasons, it would be beneficial to share it publicly.

[benjamingr]

Sure, though if we're being fair I think some people (like yourself) do a lot of this sort of unglamorous work but get little external recognition (since that typically comes in being the person who did the commit in notable changes PRs).

I think we should better highlight people doing the administrative side of work, releasers and build tool members - though that doesn't have to go through the contributor spotlight.

[mcollina]

lgtm

[mhdawson]

@anonrig the discussion was related to avoiding the creation of celebrities. Excluding voting/regular TSC members could help that, and by focusing on people behind popular features who are not on the TSC the hope was to show that "every developer" can contribute important features.

I do think we can learn what works/does not work along the way, but I also think starting out by avoiding the spotlight being on TSC members is a good way to look for contributors that might otherwise not get well deserved thanks.

[mhdawson]

I think we should better highlight people doing the administrative side of work, releasers and build tool members - though that doesn't have to go through the contributor spotlight.

I do agree with that, I think building up a group of ways that we thank contributors of all different kinds is something we should be working on.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/53694
✔  Done loading data for nodejs/node/pull/53694
----------------------------------- PR info ------------------------------------
Title      doc: exclude voting and regular TSC from spotlight (#53694)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:adjust-spotlight-elligeability -> nodejs:main
Labels     author ready
Commits    2
 - doc: exclude voting and regular TSC from spotlight
 - Update doc/contributing/reconizing-contributors.md
Committers 2
 - Michael Dawson 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/53694
Reviewed-By: Moshe Atlow 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matteo Collina 
Reviewed-By: Ruy Adorno 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53694
Reviewed-By: Moshe Atlow 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matteo Collina 
Reviewed-By: Ruy Adorno 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 02 Jul 2024 16:01:15 GMT
   ✔  Approvals: 11
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2154276245
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2154278295
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2154283773
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2154361440
   ✔  - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2154507892
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2154656746
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2156919133
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53694#pullrequestreview-2156928771
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2157362185
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2157915120
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53694#pullrequestreview-2160812494
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 53694
From https://github.com/nodejs/node
 * branch                  refs/pull/53694/merge -> FETCH_HEAD
✔  Fetched commits as 3f86bdd34e35..8189869dac4d
--------------------------------------------------------------------------------
[main 1515006da9] doc: exclude voting and regular TSC from spotlight
 Author: Michael Dawson 
 Date: Tue Jul 2 15:59:42 2024 +0000
 1 file changed, 2 insertions(+), 1 deletion(-)
[main 7944468533] Update doc/contributing/reconizing-contributors.md
 Author: Michael Dawson 
 Date: Fri Jul 5 09:45:57 2024 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc: exclude voting and regular TSC from spotlight
Signed-off-by: Michael Dawson [email protected]

PR-URL: #53694

Reviewed-By: Moshe Atlow [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Marco Ippolito [email protected]

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Ruy Adorno [email protected]

Reviewed-By: Rafael Gonzaga [email protected]

Reviewed-By: Chengzhong Wu [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: Joyee Cheung [email protected]

Reviewed-By: James M Snell [email protected]

Reviewed-By: Richard Lau [email protected]
[detached HEAD 329a1954e3] doc: exclude voting and regular TSC from spotlight

Author: Michael Dawson [email protected]

Date: Tue Jul 2 15:59:42 2024 +0000

1 file changed, 2 insertions(+), 1 deletion(-)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update doc/contributing/reconizing-contributors.md
Co-authored-by: Richard Lau [email protected]

PR-URL: #53694

Reviewed-By: Moshe Atlow [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Marco Ippolito [email protected]

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Ruy Adorno [email protected]

Reviewed-By: Rafael Gonzaga [email protected]

Reviewed-By: Chengzhong Wu [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: Joyee Cheung [email protected]

Reviewed-By: James M Snell [email protected]

Reviewed-By: Richard Lau [email protected]
[detached HEAD ea64bef174] Update doc/contributing/reconizing-contributors.md

Author: Michael Dawson [email protected]

Date: Fri Jul 5 09:45:57 2024 -0400

1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/9810016148

[nodejs-github-bot]

Landed in dca7bc5