path: use the correct name in validateString
#53669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
bpasero
changed the title
validateStringvalidateString
MoLow
approved these changes
Jul 1, 2024
lpinca
approved these changes
Jul 1, 2024
The parameter was renamed from `ext` to `suffix` but not in the `validateString` call.
|
I have updated the commit message. |
deokjinkim
approved these changes
Jul 3, 2024
deokjinkim
added
the
author ready
jasnell
approved these changes
Jul 4, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53669 ✔ Done loading data for nodejs/node/pull/53669 ----------------------------------- PR info ------------------------------------ Title path: use the correct name in `validateString` (#53669) Author Benjamin Pasero <[email protected]> (@bpasero) Branch bpasero:ben/patch-1 -> nodejs:main Labels path, author ready, needs-ci Commits 1 - path: use the correct name in `validateString` Committers 1 - Benjamin Pasero <[email protected]> PR-URL: https://github.com/nodejs/node/pull/53669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 01 Jul 2024 18:03:25 GMT ✔ Approvals: 4 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53669#pullrequestreview-2152077138 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53669#pullrequestreview-2152217364 ✔ - Deokjin Kim (@deokjinkim): https://github.com/nodejs/node/pull/53669#pullrequestreview-2156835049 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53669#pullrequestreview-2157905167 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-07-22T14:16:12Z: https://ci.nodejs.org/job/node-test-pull-request/60538/ - Querying data for job/node-test-pull-request/60538/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10058393823 |
|
Landed in f9f9a42 |
Nahee-Park
pushed a commit
to Nahee-Park/node
that referenced
this pull request
Jul 30, 2024
The parameter was renamed from `ext` to `suffix` but not in the `validateString` call. PR-URL: nodejs#53669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
The parameter was renamed from `ext` to `suffix` but not in the `validateString` call. PR-URL: #53669 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in 4a8b8d5 seems to have forgotten to update the name of the parameter in the
validateStringfunction.