Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase timeouts on some unref timers tests #5352

Closed

Conversation

Fishrock123
Copy link
Contributor

Fix: #5351
Refs: #4561
PR-URL: #5352

After #4007 lands we should consider replacing some of these tests with refed versions since they will take the same codepath.

Or add something where we can tell it to just use refed handles.

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Feb 21, 2016
@Trott
Copy link
Member

Trott commented Feb 21, 2016

LGTM

@mscdex mscdex added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Feb 21, 2016
@jasnell
Copy link
Member

jasnell commented Feb 21, 2016

LGTM

1 similar comment
@JungMinu
Copy link
Member

LGTM

@Fishrock123
Copy link
Contributor Author

guess I should probably run the CI: https://ci.nodejs.org/job/node-test-pull-request/1722/

Fishrock123 added a commit that referenced this pull request Feb 22, 2016
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@Fishrock123
Copy link
Contributor Author

landed in 65cd2a0

rvagg pushed a commit that referenced this pull request Feb 27, 2016
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants