test: mitigate flaky test-http-agent #5346
Conversation
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to exhibit flakiness around 22 or so clients. Fixes: nodejs#5184
Trott
added
http
|
Stress test showing this version of the test is not flaky: https://ci.nodejs.org/job/node-stress-single-test/517/nodes=pi2-raspbian-wheezy/console Stress test showing the version currently in master is flaky: https://ci.nodejs.org/job/node-stress-single-test/510/nodes=pi2-raspbian-wheezy/console |
|
LGTM |
|
ARM failure on CI is due to a known-flaky that Fishrock123 just fixed. Everything else looks good. |
|
This one is flaking a lot (just got another one this morning). This fix is tiny and easy to undo. And it only affects test code. So I'm going to go ahead and land it now under the "trivial changes" clause. If this is bending that rule a bit too much in anyone's opinion, let me know and I'll undo the change and/or try to be more conservative in the future. |
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to exhibit flakiness around 22 or so clients. Fixes: nodejs#5184 PR-URL: nodejs#5346 Reviewed-By: James M Snell <[email protected]>
|
Landed in bbf4621 |
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to exhibit flakiness around 22 or so clients. Fixes: #5184 PR-URL: #5346 Reviewed-By: James M Snell <[email protected]>
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to exhibit flakiness around 22 or so clients. Fixes: #5184 PR-URL: #5346 Reviewed-By: James M Snell <[email protected]>
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to exhibit flakiness around 22 or so clients. Fixes: #5184 PR-URL: #5346 Reviewed-By: James M Snell <[email protected]>
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.
Fixes: #5184