benchmark: support --help in CLI #53358
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
jasnell
approved these changes
Jun 8, 2024
lpinca
approved these changes
Jun 10, 2024
|
This hasn't seen any objections, is it good to land? |
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0260bbe |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #53358 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the CLI for the benchmarking scripts to support a
--helpargument.If any one of the arguments (including items) is
--help, the help menu will be printed instead.