debugger: remove unneeded callback check #5319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `lib/_debugger.js`, remove check for `cb` in line 571 as it is guaranteed to be truthy due to line 521.
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Feb 19, 2016
In `lib/_debugger.js`, remove check for `cb` in line 571 as it is guaranteed to be truthy due to line 521. PR-URL: #5319 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in c9d7b75 |
rvagg
pushed a commit
that referenced
this pull request
Feb 21, 2016
In `lib/_debugger.js`, remove check for `cb` in line 571 as it is guaranteed to be truthy due to line 521. PR-URL: #5319 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
In `lib/_debugger.js`, remove check for `cb` in line 571 as it is guaranteed to be truthy due to line 521. PR-URL: #5319 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
In `lib/_debugger.js`, remove check for `cb` in line 571 as it is guaranteed to be truthy due to line 521. PR-URL: #5319 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
lib/_debugger.js, remove check forcbin line 571 as it is guaranteed to be truthy due to line 521.