build: fix the extra whitespace before NINJIA_ARGS #53181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
anonrig
approved these changes
May 28, 2024
anonrig
added
fast-track
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
tniessen
removed
the
fast-track
|
Hi @tniessen, do you want me to revert this commit in this PR? I have been spending the past few hours trying to get the ninja build working as it is breaking for me as well (I am not an expert on either Makefiles or ninja and just trying to dig and learn ;)) I think I am getting close to get a fix out. Will ping you once I open that PR. |
|
@jakecastelli Let's continue the discussion in #53176. Are you on macOS by any chance? |
|
I am on MacOS m1 |
lpinca
previously approved these changes
May 28, 2024
jakecastelli
force-pushed
the
fix-passing-j32-to-ninja
branch
from
ed72a00
to
b8f6690
Compare
jakecastelli
changed the title
|
Turned out this PR I only fixed an unnecessary whitespace, but I've learned a lot ❤️ thanks everyone! |
targos
approved these changes
May 28, 2024
lpinca
approved these changes
May 28, 2024
tniessen
previously requested changes
May 28, 2024
oh good catch! @tniessen what if we change the position: |
|
Eh, I don't know — why are we trying to get rid of a single space in the output of |
Nit: My right eye twitches :-) |
|
OHHH I took this one seriously 😂 |
jakecastelli
force-pushed
the
fix-passing-j32-to-ninja
branch
from
b8f6690
to
a6ba4cb
Compare
For the couple of hours I spent on learning how Makefile works, I think I deserve a green tick 😉 just joking, I am happy to close this PR if you are object to it. |
tniessen
dismissed
their stale review
Not sure what this is accomplishing but I suppose it's not harmful either
H4ad
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53181 ✔ Done loading data for nodejs/node/pull/53181 ----------------------------------- PR info ------------------------------------ Title build: fix the extra whitespace before NINJIA_ARGS (#53181) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:fix-passing-j32-to-ninja -> nodejs:main Labels build, author ready, needs-ci Commits 1 - build: fix spacing before NINJA_ARGS Committers 1 - jakecastelli <[email protected]> PR-URL: https://github.com/nodejs/node/pull/53181 Fixes: https://github.com/nodejs/node/issues/53176 Refs: https://github.com/nodejs/node/issues/53176 Reviewed-By: Yagiz Nizipli Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53181 Fixes: https://github.com/nodejs/node/issues/53176 Refs: https://github.com/nodejs/node/issues/53176 Reviewed-By: Yagiz Nizipli Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: fix spacing before NINJA_ARGS ℹ This PR was created on Tue, 28 May 2024 01:31:35 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53181#pullrequestreview-2081601232 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53181#pullrequestreview-2082953839 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53181#pullrequestreview-2083105432 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-28T01:46:53Z: https://ci.nodejs.org/job/node-test-pull-request/59471/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - build: fix spacing before NINJA_ARGS - Querying data for job/node-test-pull-request/59471/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9424757149 |
H4ad
approved these changes
Jun 8, 2024
H4ad
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5a446cc |
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53181 Fixes: #53176 Refs: #53176 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53181 Fixes: nodejs#53176 Refs: nodejs#53176 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53181 Fixes: nodejs#53176 Refs: nodejs#53176 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53181 Fixes: #53176 Refs: #53176 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53181 Fixes: #53176 Refs: #53176 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53176 (comment)
Refs: #53176