Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove flaky mark for test-debug-no-context #5317

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 19, 2016

test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269

test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: nodejs#5269
@Trott Trott added test Issues and PRs related to the tests. lts-watch-v4.x labels Feb 19, 2016
@evanlucas
Copy link
Contributor

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Feb 19, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 19, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 19, 2016

Landed in 3144ecd

@jasnell jasnell closed this Feb 19, 2016
rvagg pushed a commit that referenced this pull request Feb 21, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
test-debug-no-context flakiness was worked around in issue 5269 but the
flaky designation was left for the test. This change removes it.

Refs: #5269
PR-URL: #5317
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the unmark branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants