Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add links to security steward companies #52981

Merged
merged 1 commit into from
Aug 6, 2024
Merged

doc: add links to security steward companies #52981

merged 1 commit into from
Aug 6, 2024

Conversation

RedYetiDev
Copy link
Member

This PR adds links to the security steward companies, in case anyone wants to visit them.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 14, 2024
@benjamingr benjamingr added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 14, 2024
benjamingr
benjamingr previously requested changes May 14, 2024
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there are foundation or project implications to this so I'd like @nodejs/tsc to weigh in on this before we land.

(I don't personally object, this just seems like the kind of thing the TSC would need to OK)

@tniessen
Copy link
Member

in case anyone wants to visit them.

This seems like yet another PR that assumes user's intentions without providing any evidence that our users actually want this.

Is the front page of the IBM website really going to provide helpful information to Node.js users or contributors? How so? That company alone employs nearly 300,000 people and I assume that 99.9 % of them have nothing to do with Node.js.

@RedYetiDev
Copy link
Member Author

This seems like yet another PR that assumes user's intentions without providing any evidence that our users actually want this.

Is the front page of the IBM website really going to provide helpful information to Node.js users or contributors? How so? That company alone employs nearly 300,000 people and I assume that 99.9 % of them have nothing to do with Node.js.

I dont think I'm assuming the user intention, but giving them an opportunity to explore, they don't have to explore these sites, but if they (for some reason) want to, they have the ability to.

mcollina
mcollina approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ShogunPanda
ShogunPanda approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhdawson mhdawson mentioned this pull request May 20, 2024
Closed
H4ad
H4ad approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice to have.

FYI @benjamingr No concerns from TSC Meeting: https://github.com/nodejs/TSC/pull/1562/files#diff-ca3f98b9fed978f61edf969c6d4aac966b16ca11f892bb9652c97f482fad72ecR59-R60

@RedYetiDev RedYetiDev removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 25, 2024
@RedYetiDev
Copy link
Member Author

Removing TSC agenda, as the meeting took place, and there were no concerns

RafaelGSS
RafaelGSS approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mhdawson
mhdawson approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@benjamingr just a ping to check if you think this should still be blocked.

@benjamingr benjamingr dismissed their stale review June 6, 2024 08:12

I totally missed dismissing my review after the TSC discussed this

@RedYetiDev
Copy link
Member Author

This has seen no objections, plus a positive TSC meeting, can it be merged?

@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2b41c23 into nodejs:main Aug 6, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2b41c23

targos pushed a commit that referenced this pull request Aug 14, 2024
@RedYetiDev @targos
doc: add links to security steward companies
88aef5a 
PR-URL: #52981
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@jasnell jasnell jasnell approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@mhdawson mhdawson mhdawson approved these changes

@H4ad H4ad H4ad approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@benjamingr benjamingr Awaiting requested review from benjamingr

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.