[v18 backport] test: add v8-updates/test-linux-perf-logger #52925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from 9c714d8 PR-URL: nodejs#50352 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
May 9, 2024
github-actions
bot
removed
the
request-ci
targos
approved these changes
May 10, 2024
richardlau
pushed a commit
that referenced
this pull request
May 16, 2024
Cherry-picked from 9c714d8 PR-URL: #50352 Backport-PR-URL: #52925 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
|
Landed in 351ef18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v18 bullet point from #51308
This patch backports the test/v8-updates/test-linux-perf-logger.js test from #50352 to the v18 branch.
Related to #50079, this test suite includes the same assertions as those done in
test/v8-updates/test-linux-perf.js. The difference is that this suite doesn't requireperf(1)to be available to CI workers. To that end, it may be the case that this test could simplify and replace the perf integration test. /cc @richardlau