src: add ASSERT_EQ style macros #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int64_t len = GET_TRUNCATE_LENGTH(args[1]); | ||
| // FIXME(bnoordhuis) It's questionable to reject non-ints here but still | ||
| // allow implicit coercion from null or undefined to zero. Probably best | ||
| // handled in lib/fs.js. |
There was a problem hiding this comment.
agreed. it's much easier to handle value coercion from JS. even if that means all there is is a minor wrapper that does a couple coercions and checks.
There was a problem hiding this comment.
Good, I'll address that in a follow-up PR.
|
LGTM |
Add ASSERT counterparts to the CHECK_EQ/CHECK_NE/etc. family of macros. PR-URL: nodejs#529 Reviewed-By: Trevor Norris <[email protected]>
Rename the misnomers ASSERT_IS_STRING_OR_BUFFER and ASSERT_IS_BUFFER. Said macros don't assert, they throw a TypeError and return. PR-URL: nodejs#529 Reviewed-By: Trevor Norris <[email protected]>
Remove a few unused or barely used macros from src/node_file.cc. PR-URL: nodejs#529 Reviewed-By: Trevor Norris <[email protected]>
bnoordhuis
force-pushed
the
assert-and-cleanup
branch
from
d0d47e7
to
668420d
Compare
This was referenced Apr 26, 2023
This was referenced Apr 27, 2023
This was referenced Jun 21, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@trevnorris?