Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid unused variable 'error' warning #52886

Merged
merged 2 commits into from
May 10, 2024
Merged

src: avoid unused variable 'error' warning #52886

merged 2 commits into from
May 10, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 8, 2024

The variable is only used in DEBUG mode. Define it only in that case.

@targos
src: avoid unused variable 'error' warning
d99e53c 
The variable is only used in DEBUG mode. Define it only in that case.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels May 8, 2024
MoLow
MoLow reviewed May 8, 2024
View reviewed changes
src/debug_utils.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59032/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 9, 2024
@targos targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit e03529e into nodejs:main May 10, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e03529e

@targos targos deleted the debug_utils-warning branch May 10, 2024 08:09
targos added a commit that referenced this pull request May 11, 2024
@targos
src: avoid unused variable 'error' warning
c40a827 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: #52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@targos @marco-ippolito
src: avoid unused variable 'error' warning
3d7d309 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: #52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@targos @marco-ippolito
src: avoid unused variable 'error' warning
f6c4bec 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: #52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@targos @marco-ippolito
src: avoid unused variable 'error' warning
2dcbf18 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: #52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@targos @eliphazbouye
src: avoid unused variable 'error' warning
19ae489 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: nodejs#52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@targos @bmeck
src: avoid unused variable 'error' warning
6c9a8e6 
The variable is only used in DEBUG mode. Define it only in that case.

PR-URL: nodejs#52886
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @benjamingr @lpinca @richardlau @MoLow