Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add module label for the lib/internal/modules folder #52858

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

RedYetiDev
Copy link
Member

This PR updates the lib/internal/modules folder to use the module label

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 6, 2024
@RedYetiDev RedYetiDev added module Issues and PRs related to the module subsystem. fast-track PRs that do not need to wait for 48 hours to land. labels May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Fast-track has been requested by @RedYetiDev. Please 👍 to approve.

@RedYetiDev
Copy link
Member Author

Fast-Tracking as this is not a major change, but rather a slight label adjustment

@RedYetiDev RedYetiDev removed the fast-track PRs that do not need to wait for 48 hours to land. label Jun 2, 2024
@RedYetiDev
Copy link
Member Author

This hasn't seen any objections, is it good to land?

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 6, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/52858
✔  Done loading data for nodejs/node/pull/52858
----------------------------------- PR info ------------------------------------
Title      meta: add module label for the lib/internal/modules folder (#52858)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     RedYetiDev:patch-15 -> nodejs:main
Labels     module, meta
Commits    2
 - meta: add module label for the lib/internal/modules folder
 - Update label-pr-config.yml
Committers 1
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/52858
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52858
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 06 May 2024 15:19:36 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52858#pullrequestreview-2051247449
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52858
From https://github.com/nodejs/node
 * branch                  refs/pull/52858/merge -> FETCH_HEAD
✔  Fetched commits as 3660ad5c9234..f0b0c4293bb2
--------------------------------------------------------------------------------
Auto-merging .github/label-pr-config.yml
[main ee854f7680] meta: add module label for the lib/internal/modules folder
 Author: Aviv Keller <[email protected]>
 Date: Mon May 6 11:19:07 2024 -0400
 1 file changed, 1 insertion(+)
Auto-merging .github/label-pr-config.yml
[main 40522e3d42] Update label-pr-config.yml
 Author: Aviv Keller <[email protected]>
 Date: Mon May 6 11:20:02 2024 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
meta: add module label for the lib/internal/modules folder

PR-URL: #52858
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD de8f2d53b6] meta: add module label for the lib/internal/modules folder
Author: Aviv Keller <[email protected]>
Date: Mon May 6 11:19:07 2024 -0400
1 file changed, 1 insertion(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update label-pr-config.yml

PR-URL: #52858
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD 8cfc905515] Update label-pr-config.yml
Author: Aviv Keller <[email protected]>
Date: Mon May 6 11:20:02 2024 -0400
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/10271857199

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit dc86592 into nodejs:main Aug 6, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in dc86592

targos pushed a commit that referenced this pull request Aug 14, 2024
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants