-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add module label for the lib/internal/modules folder #52858
Conversation
Fast-track has been requested by @RedYetiDev. Please 👍 to approve. |
Fast-Tracking as this is not a major change, but rather a slight label adjustment |
This hasn't seen any objections, is it good to land? |
Commit Queue failed- Loading data for nodejs/node/pull/52858 ✔ Done loading data for nodejs/node/pull/52858 ----------------------------------- PR info ------------------------------------ Title meta: add module label for the lib/internal/modules folder (#52858) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch RedYetiDev:patch-15 -> nodejs:main Labels module, meta Commits 2 - meta: add module label for the lib/internal/modules folder - Update label-pr-config.yml Committers 1 - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/52858 Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52858 Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 06 May 2024 15:19:36 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52858#pullrequestreview-2051247449 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52858 From https://github.com/nodejs/node * branch refs/pull/52858/merge -> FETCH_HEAD ✔ Fetched commits as 3660ad5c9234..f0b0c4293bb2 -------------------------------------------------------------------------------- Auto-merging .github/label-pr-config.yml [main ee854f7680] meta: add module label for the lib/internal/modules folder Author: Aviv Keller <[email protected]> Date: Mon May 6 11:19:07 2024 -0400 1 file changed, 1 insertion(+) Auto-merging .github/label-pr-config.yml [main 40522e3d42] Update label-pr-config.yml Author: Aviv Keller <[email protected]> Date: Mon May 6 11:20:02 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/10271857199 |
Landed in dc86592 |
PR-URL: #52858 Reviewed-By: Luigi Pinca <[email protected]>
This PR updates the
lib/internal/modules
folder to use themodule
label