Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update gyp-next to 0.18.0 #52835

Closed
wants to merge 2 commits into from
Closed

tools: update gyp-next to 0.18.0 #52835

wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented May 5, 2024 •
edited
Loading

This is an automated update of gyp-next to 0.18.0.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 5, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. labels May 5, 2024
cclauss
cclauss requested changes May 5, 2024
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two commands fail on Python 3.12 with ModuleNotFoundError: No module named 'packaging'
% pipx run --spec git+https://github.com/nodejs/gyp-next.git gyp --help
% pipx run --spec git+https://github.com/nodejs/gyp-next.git gyp --version

This was fixed in the past by:

Also discussed in:

@nodejs-github-bot nodejs-github-bot changed the title tools: update gyp-next to 0.17.0 tools: update gyp-next to 0.18.0 May 9, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59053/

@targos targos added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label May 9, 2024
@cclauss
Copy link
Contributor

cclauss commented May 9, 2024 •
edited
Loading

Should we wait on this fix for gyp --version on Python >= 3.12?

@cclauss cclauss self-requested a review May 9, 2024 14:20
@targos
Copy link
Member

targos commented May 9, 2024

I'd say no because it doesn't matter for the usage in this project

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/59060/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 70995bd...a923fed

nodejs-github-bot added a commit that referenced this pull request May 9, 2024
@nodejs-github-bot
tools: update gyp-next to 0.17.0
62294f9 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
nodejs-github-bot added a commit that referenced this pull request May 9, 2024
@nodejs-github-bot
tools: update gyp-next to 0.18.0
a923fed 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@richardlau richardlau deleted the actions/tools-update-gyp-next branch May 9, 2024 21:02
targos pushed a commit that referenced this pull request May 11, 2024
@nodejs-github-bot @targos
tools: update gyp-next to 0.17.0
c5f832a 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit that referenced this pull request May 11, 2024
@nodejs-github-bot @targos
tools: update gyp-next to 0.18.0
8ce23dc 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request May 13, 2024
Merged
@mhdawson mhdawson mentioned this pull request May 13, 2024
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@nodejs-github-bot @marco-ippolito
tools: update gyp-next to 0.17.0
e47e009 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@nodejs-github-bot @marco-ippolito
tools: update gyp-next to 0.18.0
aec4f40 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@nodejs-github-bot @marco-ippolito
tools: update gyp-next to 0.17.0
ffd57b9 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@nodejs-github-bot @marco-ippolito
tools: update gyp-next to 0.18.0
0cd7dcf 
PR-URL: #52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Jun 17, 2024
@marco-ippolito
Copy link
Member

this breaks v20.x build https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian10-x64/58454/console

@cclauss
Copy link
Contributor

cclauss commented Jun 17, 2024 •
edited
Loading

Test is running on Python 3.7 which is no longer supported:

Node.js configure: Found Python 3.7.3...
10:02:34 Traceback (most recent call last):
10:02:34   File "./configure", line 29, in <module>
10:02:34     import configure
10:02:34   File "/home/iojs/build/workspace/node-test-commit-linux/configure.py", line 30, in <module>
10:02:34     from gyp.common import GetFlavor
10:02:34   File "tools/gyp/pylib/gyp/__init__.py", line 9, in <module>
10:02:34     import gyp.input
10:02:34   File "tools/gyp/pylib/gyp/input.py", line 8, in <module>
10:02:34     import gyp.common
10:02:34   File "tools/gyp/pylib/gyp/common.py", line 435
10:02:34     if CC := os.environ.get("CC_target") or os.environ.get("CC"):
10:02:34            ^
10:02:34 SyntaxError: invalid syntax

Assignment expression https://docs.python.org/3/whatsnew/3.8.html

eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@nodejs-github-bot @eliphazbouye
tools: update gyp-next to 0.17.0
bc79a28 
PR-URL: nodejs#52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@nodejs-github-bot @eliphazbouye
tools: update gyp-next to 0.18.0
37d5ba7 
PR-URL: nodejs#52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@nodejs-github-bot @bmeck
tools: update gyp-next to 0.17.0
3953b03 
PR-URL: nodejs#52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@nodejs-github-bot @bmeck
tools: update gyp-next to 0.18.0
b16d009 
PR-URL: nodejs#52835
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@cclauss cclauss cclauss approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nodejs-github-bot @cclauss @targos @marco-ippolito @lpinca @legendecas