Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add more definitions to GLOSSARY.md #52798

Merged
merged 6 commits into from
May 5, 2024

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented May 2, 2024

Continuation of #31879, as no action from the author was taken in several years.

This PR uses the terms/definitions from the original PR and adds more. Additionally, the requested changes from that PR were also taken into account.

Supersedes: #31879

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 2, 2024
@RedYetiDev RedYetiDev added the meta Issues and PRs related to the general management of the project. label May 2, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 2, 2024

Can you add the original author as a co-author please?

@RedYetiDev
Copy link
Member Author

Sure thing, I must've forgotten when I typed up the commit.

@aduh95
Copy link
Contributor

aduh95 commented May 3, 2024

Could you move the renaming of the file to simplifies reviews and avoid resetting the git blame? The renaming could probably be fast-tracked as it would be fairly trivial to review.

glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
GLOSSARY.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Show resolved Hide resolved
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a few nits left

glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
glossary.md Outdated Show resolved Hide resolved
RedYetiDev and others added 3 commits May 5, 2024 16:04
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2024
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit f500107 into nodejs:main May 5, 2024
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f500107

@RedYetiDev RedYetiDev deleted the patch-2 branch May 5, 2024 22:33
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
Co-Authored-By: Harshitha KP <[email protected]>
PR-URL: nodejs#52798
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request May 8, 2024
Co-Authored-By: Harshitha KP <[email protected]>
PR-URL: #52798
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
Co-Authored-By: Harshitha KP <[email protected]>
PR-URL: #52798
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
Co-Authored-By: Harshitha KP <[email protected]>
PR-URL: nodejs#52798
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Co-Authored-By: Harshitha KP <[email protected]>
PR-URL: nodejs#52798
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants