Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: preserve hook promise when executed twice #52791

Merged
merged 1 commit into from
May 4, 2024
Merged

test_runner: preserve hook promise when executed twice #52791

merged 1 commit into from
May 4, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented May 2, 2024

Fixes #52764

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. util Issues and PRs related to the built-in util module. labels May 2, 2024
cjihrig
cjihrig approved these changes May 2, 2024
View reviewed changes
test/fixtures/test-runner/output/hooks.js Outdated Show resolved Hide resolved
@MoLow MoLow requested a review from cjihrig May 2, 2024 14:04
benjamingr
benjamingr reviewed May 2, 2024
View reviewed changes
lib/internal/util.js Outdated Show resolved Hide resolved
@MoLow MoLow requested a review from benjamingr May 3, 2024 09:04
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58890/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58902/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58932/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58933/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58934/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit 44287af into nodejs:main May 4, 2024
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 44287af

@MoLow MoLow deleted the preserve-hook-result branch May 4, 2024 22:55
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@MoLow
test_runner: preserve hook promise when executed twice
00e101c 
PR-URL: nodejs#52791
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request May 8, 2024
@MoLow @targos
test_runner: preserve hook promise when executed twice
b96868b 
PR-URL: #52791
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request May 13, 2024
Merged
@cjihrig cjihrig mentioned this pull request May 17, 2024
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@MoLow @marco-ippolito
test_runner: preserve hook promise when executed twice
cf817e1 
PR-URL: #52791
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@MoLow @EliphazBouye
test_runner: preserve hook promise when executed twice
f45371f 
PR-URL: nodejs#52791
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@MoLow @bmeck
test_runner: preserve hook promise when executed twice
fb8cb1d 
PR-URL: nodejs#52791
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test runner runs beforeEach or test case before "before hook" finished
5 participants
@MoLow @nodejs-github-bot @benjamingr @cjihrig @atlowChemi