Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: fix debugger blocked main thread #5270

Closed
wants to merge 1 commit into from
Closed

debugger: fix debugger blocked main thread #5270

wants to merge 1 commit into from

Conversation

yjhjstz
Copy link

@yjhjstz yjhjstz commented Feb 17, 2016

see #2110
Call uv_walk to close all handles， otherwise would meat error below.

Assertion failed: ((err) == (0)), function Stop, file ../src/debug-agent.cc, line 156.

@yjhjstz yjhjstz mentioned this pull request Feb 17, 2016
Closed
@jasnell
Copy link
Member

jasnell commented Feb 17, 2016

/cc @piscisaureus @bnoordhuis @thealphanerd

@bnoordhuis
Copy link
Member

I don't think blindly closing all handles is the best way to fix this (although it's certainly the easiest) because it introduces memory leaks and corrupts the HandleWrap linked list. #2133 has a solution for cleaning up handles at exit.

@yjhjstz
Copy link
Author

yjhjstz commented Feb 23, 2016

yes, in fact I just want to close tty handle. but will #2133 to be merge?

@bnoordhuis
Copy link
Member

Perhaps we can land the cleanup changes. I don't really have time to review it, though.

@bnoordhuis bnoordhuis mentioned this pull request Mar 9, 2016
Closed
@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

@thealphanerd ... any thoughts on this one?

@MylesBorins MylesBorins self-assigned this Mar 24, 2016
@MylesBorins
Copy link
Contributor

Nothing off the top of my head. I've assigned it to myself and will investigate

@MylesBorins MylesBorins assigned indutny and unassigned MylesBorins Apr 8, 2016
@MylesBorins
Copy link
Contributor

@indutny did you have a chance to check this out, it seems like you gave the origin review in #2110

@MylesBorins
Copy link
Contributor

the test is failing for me locally on osx

@MylesBorins MylesBorins mentioned this pull request Apr 8, 2016
Closed
@jjqq2013
Copy link
Contributor

+1

@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:01
@MylesBorins
Copy link
Contributor

Is this something we want to try and fix in LTS?

@jasnell
Copy link
Member

jasnell commented Dec 29, 2016

Possibly. If there is no negative impact then I don't see why not.

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Feb 28, 2017
@jasnell
Copy link
Member

jasnell commented Mar 1, 2017

@MylesBorins ... is this still needed? given that the debugger is deprecated and going away, I'm inclined to close

@MylesBorins
Copy link
Contributor

@jasnell I'm open to closing it... that being said if it can fix 4.x it may be worth it. No one is stepping up to do it though...

@jjqq2013
Copy link
Contributor

jjqq2013 commented Mar 1, 2017 •
edited
Loading

This is a confusing problem, causing debugger not automatically exited. We should fix it

@fhinkel
Copy link
Member

fhinkel commented Mar 26, 2017

Feel free to reopen this PR if you get back to working on it.

@fhinkel fhinkel closed this Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@indutny indutny

Labels
stalled Issues and PRs that are stalled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yjhjstz @jasnell @bnoordhuis @MylesBorins @jjqq2013 @fhinkel @mscdex @indutny