Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update lint-md-dependencies #52581

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 18, 2024

[email protected]
[email protected]

I know we have tooling that does this once a week or whatever, but I'm eager to get the new remark-preset-lint-node deployed. It shouldn't have any breaking changes, but there were a lot of dependency updates, so I want to make sure CI doesn't hold any surprises.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 18, 2024
@Trott
Copy link
Member Author

Trott commented Apr 18, 2024

I'm adding the label to request full CI because lint-md.mjs has changed and that can (rarely) cause problems for one or two of the Jenkins bots, IIRC.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2024
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 18, 2024
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit d545984 into nodejs:main Apr 19, 2024
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d545984

@Trott Trott deleted the update-lint-md-deps branch April 19, 2024 17:08
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
[email protected]
[email protected]

PR-URL: #52581
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
[email protected]
[email protected]

PR-URL: #52581
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
[email protected]
[email protected]

PR-URL: #52581
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants