doc: correct stream.finished changes #52551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
climba03003
commented
Apr 16, 2024
doc/api/stream.md
Outdated
Comment on lines
242
to
243
| - v18.14.0 | ||
| - v20.0.0 |
There was a problem hiding this comment.
3225498 shows it is added starting from v20.0.0
cde59606cd shows it is backported to v18.14.0
Ayase-252
approved these changes
Apr 16, 2024
lpinca
approved these changes
Apr 16, 2024
lpinca
approved these changes
Apr 16, 2024
Co-authored-by: Luigi Pinca <[email protected]>
benjamingr
reviewed
Apr 16, 2024
benjamingr
reviewed
Apr 16, 2024
doc/api/stream.md
Outdated
| @@ -241,7 +241,7 @@ changes: | |||
| - version: | |||
| - v19.5.0 | |||
| - v18.14.0 | |||
| pr-url: https://github.com/nodejs/node/pull/46205 | |||
| pr-url: https://github.com/nodejs/node/pull/52551 | |||
There was a problem hiding this comment.
Sorry, that was a brainfart :D the lint tricked me
benjamingr
reviewed
Apr 16, 2024
benjamingr
added
the
commit-queue-squash
debadree25
approved these changes
Apr 16, 2024
debadree25
added
the
author ready
aymen94
approved these changes
Apr 17, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 93da936 |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52551 Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52551 Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52551 Reviewed-By: Qingyu Deng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52544