doc: document base64url encoding support #5243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documenting per @bnoordhuis 's suggestion in #5239 |
mscdex
added
buffer
|
LGTM but @nodejs/documentation, for when you land this, I think there is a long line in the commit log. |
|
Yes, missed it by one :( |
|
LGTM (other than the commit line thing :P) |
Documents that creating a buffer from base64 encoded string transparently supports "URL and Filename Safe Alphabet" base64url encoding.
|
force pushed fixing line length |
|
LGTM |
silverwind
pushed a commit
that referenced
this pull request
Feb 27, 2016
Documents that creating a buffer from base64 encoded string transparently supports "URL and Filename Safe Alphabet" base64url encoding. PR-URL: #5243 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Alejandro Oviedo <[email protected]>
|
Thanks! Landed in 1411e0b. |
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2016
Documents that creating a buffer from base64 encoded string transparently supports "URL and Filename Safe Alphabet" base64url encoding. PR-URL: #5243 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Alejandro Oviedo <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Documents that creating a buffer from base64 encoded string transparently supports "URL and Filename Safe Alphabet" base64url encoding. PR-URL: #5243 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Alejandro Oviedo <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Documents that creating a buffer from base64 encoded string transparently supports "URL and Filename Safe Alphabet" base64url encoding. PR-URL: #5243 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Alejandro Oviedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents that creating a buffer from base64 encoded string transparently
supports "URL and Filename Safe Alphabet" base64url encoding.