-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: run test-asan on ubuntu-24.04 #52374
Conversation
Review requested:
|
If it still fails, I hope we can use this PR to collaborate on finding a real fix for #45578. |
|
/cc @nodejs/single-executable |
I hoped to get more information from a debug build but it's not reproducible with it! |
Should we try with |
|
I suggest to wait for #52406 and retry. |
Guess based on the stack trace:
|
5d178a9
to
df7429a
Compare
@nodejs/cpp-reviewers Does this make sense to you?
|
What I understand is it points to Lines 119 to 123 in 97627da
Where an array is allocated. Then somewhere we use |
What I see are reports about an issue in old code contributed by @addaleax It seems unclear to me (though not impossible) there there is a defect in this code. Possibly we are encountering a false positive. |
Something does not add up. The trace has...
But |
Let us try to rerun the tests. |
4f11861
to
74f8aaa
Compare
rebased |
Since the problem only happens with SEA tests, where the binary is patched, it's possible that the debug output is a red herring. |
Right. So we are being mislead as to where the issue is actually happening? |
It's a hypothesis. I don't really know what's happening. |
Oh, results with latest Clang are much more interesting! |
Here are all the errors from the above actions run
|
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: nodejs#52374 Refs: nodejs#53651 (comment)
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: nodejs#52374 Refs: nodejs#53651 (comment) PR-URL: nodejs#53844 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closes: #45578
The only way to know if it works is to try.