Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: replace MessageEvent with undici's #52370

Merged
merged 1 commit into from
Apr 29, 2024

Commits on Apr 4, 2024

  1. lib: replace MessageEvent with undici's

    undici's MessageEvent is better tested and has a complete WebIDL
    implementation for validation. Not only this, but it's also used in
    Node's  current WebSocket implementation. There are a large number of
    webidl-related issues in the current MessageEvent, such as not
    implementing `MessageEvent.prototype.initMessageEvent`, not validating
    arguments passed to its constructor
    (nodejs#51771), not validating the values
    passed to the constructor (such as not validating that `ports` is a
    sequence, not converting origin to a USVString, etc.), and other issues.
    
    fixup
    KhafraDev committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f126982 View commit details
    Browse the repository at this point in the history