Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: fix no data on partial decode #5226

Closed
wants to merge 1 commit into from

Commits on Feb 14, 2016

  1. stream: fix no data on partial decode

    Before this commit, it was possible to push a partial character
    to a readable stream where it was decoded as an empty string and
    then added to the internal buffer. This caused the stream to not
    emit any data, even when the rest of the character bytes were pushed
    separately, because of a non-zero length check of the first chunk in
    the internal buffer.
    
    Fixes: nodejs#5223
    mscdex committed Feb 14, 2016
    Configuration menu
    Copy the full SHA
    bbabbee View commit details
    Browse the repository at this point in the history