Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update zlib to 1.3.0.1-motley-24c07df #52199

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of zlib to 1.3.0.1-motley-24c07df.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Mar 24, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 24, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 24, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@lpinca
Copy link
Member

lpinca commented Mar 24, 2024

@nodejs/platform-riscv64 @luyahan riscv64 is not yet a supported platform so I think it does not make sense to enable the optimizations.

@nodejs-github-bot
Copy link
Collaborator Author

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit 38161c3 into main Mar 27, 2024
69 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-zlib branch March 27, 2024 19:53
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 38161c3

@sxa
Copy link
Member

sxa commented Mar 28, 2024

@nodejs/platform-riscv64 Does this risk any problems on TH1520 and similar systems which do not have the final 1.0 version of RVV but may advertise themselves as having that capability?

marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52199
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52199
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
richardlau pushed a commit that referenced this pull request May 16, 2024
PR-URL: #52199
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants