Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: emit listening event once when call listen twice #52119

Merged
merged 1 commit into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -1969,7 +1969,11 @@ function listenInCluster(server, address, port, addressType,
const ex = new ExceptionWithHostPort(err, 'bind', address, port);
return server.emit('error', ex);
}

// If there was a handle, just close it to avoid fd leak
// but it doesn't look like that's going to happen right now
if (server._handle) {
server._handle.close();
}
// Reuse primary's server handle
server._handle = handle;
// _listen2 sets up the listened handle, it is still named like this
Expand Down Expand Up @@ -1998,6 +2002,8 @@ Server.prototype.listen = function(...args) {

options = options._handle || options.handle || options;
const flags = getFlags(options.ipv6Only);
// Refresh the id to make the previous call invalid
this._listeningId++;
// (handle[, backlog][, cb]) where handle is an object with a handle
if (options instanceof TCP) {
this._handle = options;
Expand Down
38 changes: 38 additions & 0 deletions test/parallel/test-net-listen-twice.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
'use strict';
const common = require('../common');
const net = require('net');
const cluster = require('cluster');
const assert = require('assert');

if (cluster.isPrimary) {
const worker = cluster.fork();
worker.on('exit', common.mustCall((code) => {
assert.ok(code === 0);
}));
} else {
const server = net.createServer();
server.listen();
try {
// Currently, we can call `listen` twice in cluster worker,
// if we can not call `listen` twice in the futrue,
// just skip this test.
server.listen();
} catch (e) {
console.error(e);
process.exit(0);
}
let i = 0;
process.on('internalMessage', (msg) => {
if (msg.cmd === 'NODE_CLUSTER') {
if (++i === 2) {
setImmediate(() => {
server.close(() => {
process.disconnect();
});
});
}
}
});
// Must only call once
server.on('listening', common.mustCall());
}
Loading