Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to npm 3.7.2 #5211

Closed
wants to merge 1 commit into from
Closed

deps: upgrade to npm 3.7.2 #5211

wants to merge 1 commit into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Feb 13, 2016

Hey! Rebecca's out, so I'm doing the npm@3 thing this week.

This includes the following releases:

Notable changes:

  • c680fa9 [email protected]: New are-we-there-yet with performance patches from @STRML. New gauge with timer churn performance patch. This is the make-the-progress-bar-not-slow-stuff-down patch. (@iarna)
  • 39dea9c #1876 (New Feature) Add support for git submodules in git remotes. (@gagern)
  • doc and bug fixes

r: @Fishrock123
r: @jasnell
r: @mikeal
r: @thealphanerd

@zkat zkat added npm Issues and PRs related to the npm client dependency or the npm registry. land-on-v5.x labels Feb 13, 2016
@MylesBorins
Copy link
Contributor

@zkat should we close #5097 in lieu of this update?

@MylesBorins
Copy link
Contributor

@jasnell do we want to land this on master or on v5.x?

@MylesBorins
Copy link
Contributor

I have patched this on top of v5.x and the test suite passes.

#5212 just came in which removes some deps from the 3.6 release for having too long of a path. Just wanted to bring it to attention

/cc @mscdex

@zkat
Copy link
Contributor Author

zkat commented Feb 13, 2016

@thealphanerd Oh! Welp, that's why I failed to find it. My quick search for dep upgrades is deps: npm, and I didn't see anything after 3.6.0 so I assumed all three of these were there.

I'd say to have this one supplant that one, yes. At least that's what we've done with LTS releases.

@MylesBorins
Copy link
Contributor

sgtm... closing the other one 😄

@MylesBorins
Copy link
Contributor

CITGM run rebased against v5.x: https://ci.nodejs.org/job/thealphanerd-smoker/90/

edit: It looks like v3.7.3 is actually ready to come downstream. As such I'd like to advise that we close this PR and #5212 in lieu of the new PR @zkat is putting together right now which should fix npm on master. This PR should be cherry-picked to v5.x and included in the v5.7.0 release

/cc @rvagg @Fishrock123

@zkat zkat mentioned this pull request Feb 22, 2016
@zkat
Copy link
Contributor Author

zkat commented Feb 22, 2016

Closing this one in favor of #5369.

@zkat zkat closed this Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants