lib: return directly if udp socket close before lookup #51914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dgram
anonrig
reviewed
Feb 28, 2024
github-actions
bot
removed
the
request-ci
ShogunPanda
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
I second @anonrig's recommendations but they are not really blockers.
theanarkh
force-pushed
the
udp_bind_return_if_destroy_socket_before_dns
branch
from
c348000 to
061dcbb
Compare
github-actions
bot
removed
the
request-ci
theanarkh
added
the
author ready
lpinca
approved these changes
Feb 29, 2024
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d405a60 |
targos
pushed a commit
that referenced
this pull request
Mar 7, 2024
PR-URL: #51914 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51914 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51914 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#51914 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return directly in callback which is called by lookup when udp socket is closed.
make -j4 test(UNIX), orvcbuild test(Windows) passes