Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix empty string access in dotenv #51757

Closed
wants to merge 1 commit into from
Closed

src: fix empty string access in dotenv #51757

wants to merge 1 commit into from

Conversation

victorgomes
Copy link

The value string added in (#51289) can sometimes be empty. We check for it before accessing it.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 14, 2024
@Flarna
Copy link
Member

Flarna commented Feb 14, 2024

seems to be a duplicate of #51665

@mertcanaltin mertcanaltin added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Feb 14, 2024
@victorgomes
Copy link
Author

seems to be a duplicate of #51665

Indeed.

@victorgomes victorgomes deleted the fix-empty-string branch February 14, 2024 15:19
@victorgomes victorgomes mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. duplicate Issues and PRs that are duplicates of other issues or PRs. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorgomes @Flarna @nodejs-github-bot @mertcanaltin