Updating to DCO 1.1 #5170
Closed
Updating to DCO 1.1 #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
meta
|
LGTM |
| @@ -173,19 +173,28 @@ to address, apply your changes in a separate commit and push that to your | |||
| feature branch. Post a comment in the pull request afterwards; GitHub does | |||
| not send out notifications when you add commits. | |||
|
|
|||
|
|
|||
| ## Developer's Certificate of Origin 1.0 | |||
| # Developer's Certificate of Origin 1.1 | |||
|
lgtm sans style nit |
|
Fixed the style nit. |
|
Should we link the source? I could find the text here http://developercertificate.org. Change LGTM. |
|
We can't modify the text in any way so if we did a link it would have to a linkified header. Stylistically we don't do that anywhere else. |
|
Then its okay. I was just wondering if it is okay to copy the text without the source. |
|
From the site:
|
|
LGTM except for the commit log. |
|
LGTM as long as commits are updated |
rvagg
pushed a commit
that referenced
this pull request
Feb 12, 2016
PR-URL: #5170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
squashed and commit msg updated, landed @ d78e679 |
rvagg
pushed a commit
that referenced
this pull request
Feb 15, 2016
PR-URL: #5170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
Looks like this landed? Closing.. |
|
whoops, thanks @Fishrock123 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #5170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #5170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
stefanmb
pushed a commit
to stefanmb/node
that referenced
this pull request
Feb 23, 2016
PR-URL: nodejs#5170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #5170 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be using the latest version of the DCO approved by lawyers who know more about all of this than we do :)