-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip test-http-correct-hostname on loong64 #51663
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Feb 4, 2024
lpinca
approved these changes
Feb 5, 2024
edsadr
approved these changes
Feb 6, 2024
ping~ Best regards |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 18, 2024
mhdawson
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mhdawson
pushed a commit
that referenced
this pull request
Feb 20, 2024
PR-URL: #51663 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Landed in 2eaee28 |
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR-URL: #51663 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 20, 2024
PR-URL: nodejs#51663 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51663 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51663 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Adrian Estrada <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
log: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/75/console
issues: #51662
In common user machines, the test case can pass normally. I guess it is the machine local area network problem of "node-test-commit-loongarch64/nodes=clfs23-64". It is recommended to skip this test item for the time being.
Best regards