build: remove librt library dependency for Android compatibility
#51632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MeowShe
changed the title
librt lib link for Android compatibilitylibrt library dependency for Android compatibility
lpinca
approved these changes
Feb 1, 2024
github-actions
bot
removed
the
request-ci
|
Could we re-request CI again? |
It is under security embargo. |
Anything should I do for that? |
|
No, thank you. |
joyeecheung
approved these changes
Feb 24, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 56ced19 |
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR-URL: #51632 Fixes: #50184 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR-URL: #51632 Fixes: #50184 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 27, 2024
PR-URL: #51632 Fixes: #50184 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51632 Fixes: #50184 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51632 Fixes: #50184 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#51632 Fixes: nodejs#50184 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #50184
Remove
librtlibrary dependency when building Node.js for Android, as it does not exist on Android.Related to PR #51646, as part of a series of build fixes for Android.