Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fs: deprecate fs.read's string interface" #5163

Closed
wants to merge 2 commits into from
Closed

Revert "fs: deprecate fs.read's string interface" #5163

wants to merge 2 commits into from

Commits on Feb 9, 2016

  1. Revert "fs: deprecate fs.read's string interface" 

    This reverts commit 1124de2
which landed in nodejs#4525

This commit has broken both npm + node-gyp

How did it break npm?

Deprecating fs.read's string interface includes `internal/util`
Currently npm's dep tree includes an old version of graceful-fs
that is monkey patching fs. As such everything explodes when
trying to require `internal/util`

nodejs#5102 is waiting for review
but has not landed. We should revert ASAP to fix master while
we decide what to do.
    Myles Borins committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    3e32ff5 View commit details
    Browse the repository at this point in the history

  2. test: add test-npm-install to parallel tests suite 

    Currently we are not testing that `npm install` works.

This is a very naive / basic test that shells out to `npm install`
in an empty `tempDir`. While this test will not be able to check
that `npm install` is 100% working, it should catch certain edge
cases that break it.
    Myles Borins committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    7453d72 View commit details
    Browse the repository at this point in the history