Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "deps: V8: cherry-pick 13192d6e10fa" #51495

Closed
wants to merge 1 commit into from
Closed

Revert "deps: V8: cherry-pick 13192d6e10fa" #51495

wants to merge 1 commit into from

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Jan 17, 2024 •
edited by richardlau
Loading

This reverts commit bc2ebb9, which shouldn't be applied to v20.x.

Fixes: nodejs/unofficial-builds#106

@kxxt
Revert "deps: V8: cherry-pick 13192d6e10fa"
dda5cdb 
This reverts commit bc2ebb9, which
shouldn't be applied to v20.x.

Fix nodejs/unofficial-builds#106
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Jan 17, 2024
@kxxt kxxt mentioned this pull request Jan 17, 2024
Open
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2024
@richardlau richardlau added the riscv64 Issues and PRs related to the riscv64 architecture. label Jan 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56822/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5775/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5775/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5775/

KexyBiscuit added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Jan 18, 2024
@KexyBiscuit
nodejs: apply nodejs/node#51495 to fix build on riscv64
8a34683
KexyBiscuit added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Jan 18, 2024
@KexyBiscuit
nodejs: apply nodejs/node#51495 to fix build on riscv64
42d02ca
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56845/

MingcongBai pushed a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Jan 20, 2024
@KexyBiscuit @MingcongBai
nodejs: apply nodejs/node#51495 to fix build on riscv64
77a775b
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56887/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56890/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2024
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Feb 7, 2024
@kxxt
updpatch: nodejs-lts-iron
48e931f 
Revert a v8 cherry-pick that targets v21 but incorrectly gets backported
to v20.

Upstream PR:  nodejs/node#51495
@kxxt kxxt mentioned this pull request Feb 7, 2024
Merged
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Feb 7, 2024
@kxxt @felixonmars
updpatch: nodejs-lts-iron
14793a1 
Revert a v8 cherry-pick that targets v21 but incorrectly gets backported
to v20.

Upstream PR:  nodejs/node#51495
@richardlau richardlau mentioned this pull request Mar 5, 2024
Open
richardlau pushed a commit that referenced this pull request Mar 5, 2024
@kxxt @richardlau
Revert "deps: V8: cherry-pick 13192d6e10fa"
ea50540 
This reverts commit bc2ebb9, which
shouldn't be applied to v20.x.

Fix nodejs/unofficial-builds#106

PR-URL: #51495
Fixes: nodejs/unofficial-builds#106
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau
Copy link
Member

Landed in ea50540.

@richardlau richardlau closed this Mar 5, 2024
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. riscv64 Issues and PRs related to the riscv64 architecture. v8 engine Issues and PRs related to the V8 dependency. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kxxt @nodejs-github-bot @richardlau @fhinkel @lpinca @targos @sxa @panva