build: do not rely on gn_helpers in GN build #51439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
zcbenz
force-pushed
the
remove-gn-helper-dep
branch
from
f487772 to
8c12697
Compare
anonrig
approved these changes
Jan 12, 2024
github-actions
bot
removed
the
request-ci
aymen94
approved these changes
Jan 12, 2024
zcbenz
force-pushed
the
remove-gn-helper-dep
branch
from
8c12697 to
0f8d7d5
Compare
github-actions
bot
removed
the
request-ci
zcbenz
force-pushed
the
remove-gn-helper-dep
branch
from
0f8d7d5 to
9b6d263
Compare
github-actions
bot
removed
the
request-ci
zcbenz
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51439 ✔ Done loading data for nodejs/node/pull/51439 ----------------------------------- PR info ------------------------------------ Title build: do not rely on gn_helpers in GN build (#51439) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:remove-gn-helper-dep -> nodejs:main Labels build, tools, needs-ci, gyp, quic Commits 1 - build: do not rely on gn_helpers in GN build Committers 1 - Cheng Zhao PR-URL: https://github.com/nodejs/node/pull/51439 Reviewed-By: Yagiz Nizipli Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51439 Reviewed-By: Yagiz Nizipli Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: do not rely on gn_helpers in GN build ℹ This PR was created on Fri, 12 Jan 2024 00:57:41 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51439#pullrequestreview-1817092470 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/51439#pullrequestreview-1819939080 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51439#pullrequestreview-1844641924 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-23T09:59:42Z: https://ci.nodejs.org/job/node-test-pull-request/57339/ - Querying data for job/node-test-pull-request/57339/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8018573136 |
zcbenz
added a commit
that referenced
this pull request
Feb 23, 2024
PR-URL: #51439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in f04abdb |
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR-URL: #51439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR-URL: #51439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 27, 2024
PR-URL: #51439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#51439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the GN build more friendly for non-Chromium environment: