Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: update iterations of benchmark/assert/deepequal-prims-and- #51418

Conversation

lucshi
Copy link

@lucshi lucshi commented Jan 10, 2024

Before applying this PR, the top functions are reading test JS file, instead of real logic code of "equal".
After increasing the iteration value, the test case behaved as expected to trigger equal.

Fixes: #50571

<style> </style>
        after PR before PR benefit
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="string": 82108898.08 20848813.58 394%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="string": 77290306.95 20177774.26 383%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="string": 78842261.31 19873987 397%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="number": 98850184.54 21289722.9 464%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="number": 96007702.12 20964083.7 458%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="number": 92423466.21 20005853.71 462%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="boolean": 81081300.22 22822739.21 355%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="boolean": 79017334.11 20538355.48 385%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="boolean": 70408374.2 21118222.56 333%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="object": 9513541.966 5570178.512 171%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="object": 3597408.18 2832380.167 127%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="object": 10942811.04 6509602.543 168%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="object_other_property": 85124414.87 21339647.59 399%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="object_other_property": 81708852.4 21077032.13 388%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="object_other_property": 7842163.96 21671942.7 362%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="array": 3063527.91 2554561.996 120%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="array": 3012416.415 2471627.386 122%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="array": 3163574.552 2573358.539 123%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="set_object": 1850845.414 1594034.612 116%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="set_object": 1383354.937 1231175.223 112%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="set_object": 1394540.187 1248346.331 112%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="set_simple": 5028757.908 3776117.897 133%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="set_simple": 2575976.329 1950982.501 132%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="set_simple": 2627620.396 2198281.133 120%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="circular": 6068547.656 4182957.368 145%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="circular": 1856768.185 1638896.978 113%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="circular": 2755222.577 2313574.107 119%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="empty_object": 2270300.76 11347600.14 200%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="empty_object": 5143817.247 4236321.321 121%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="empty_object": 26501986.15 15019949.5 176%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="regexp": 9131840.741 6256685.268 146%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="regexp": 3137963.86 2820466.001 111%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="regexp": 8465537.731 6087401.326 139%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=0 primitive="date": 8055727.006 5812202.056 139%
assert/deepequal-prims-and-objs-big-loop.js method="deepEqual" strict=1 primitive="date": 3359964.592 2940010.411 114%
assert/deepequal-prims-and-objs-big-loop.js method="notDeepEqual" strict=1 primitive="date": 7530881.623 5624093.256 134%

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jan 10, 2024
@lucshi lucshi force-pushed the benchmark/assert/deepequal-prims-and-objs-big-loop.js branch from ad151ed to 930a012 Compare January 10, 2024 06:36
@lucshi lucshi closed this Mar 1, 2024
@lucshi lucshi deleted the benchmark/assert/deepequal-prims-and-objs-big-loop.js branch March 1, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes
2 participants