Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appendHeader to HTTP/2 compat API and fix issues with duplicate headers in H2 writeHead #51412

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Add appendHeader to HTTP/2 compat API and fix issues with duplicate headers in H2 writeHead #51412

merged 2 commits into from
Jan 12, 2024

Commits on Jan 9, 2024

  1. http2: add h2 compat support for appendHeader

    @pimterry
    pimterry committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5291a8e View commit details
    Browse the repository at this point in the history

  2. http2: fix compat bug where duplicate headers were lost in writeHead 

    Previously if an array of raw headers was provided to writeHead, and
that array contained any duplicate keys, only the last value was
recorded for that key and all others were lost.

This changes bring the HTTP/2 compat logic in line with the logic for
HTTP/1, so that writeHead headers overwrite any previous conflicting
setHeader headers, but do not overwrite themselves.
    @pimterry
    pimterry committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    c7367e4 View commit details
    Browse the repository at this point in the history