Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v0.12.10 (LTS) #5137

Closed
wants to merge 5 commits into from
Closed

Release proposal: v0.12.10 (LTS) #5137

wants to merge 5 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 8, 2016

Security release, to go out ~ Tuesday, the 9th of February, 11pm UTC with releases across all active lines as per https://groups.google.com/d/msg/nodejs-sec/G8IA0G4uA88/So3Cw84YDwAJ.

Commits so far:

Pending additions being worked on by the security team, I'll get everything else ready here and finish it off in our private repo. Still needs "Notable items" filled out for OpenSSL.

Commits still on v0.12-staging that we'll have to get to in a v0.12.11 soon after this release:

  • [fbc8cd9bbd] - deps: backport 1f8555 from v8's upstream (Trevor Norris) #3945
  • [16417cc75a] - domains: fix handling of uncaught exceptions (Julien Gilli) #3885
  • [9abceadaeb] - node: fix leaking Context handle (Trevor Norris) #3945
  • [801f6ad8a3] - src: fix build error without OpenSSL support (Jörg Krause) #4201
  • [409f6a9d30] - src: use global SealHandleScope (Trevor Norris) #3945
  • [1effbd7b65] - test: add test-domain-exit-dispose-again back (Julien Gilli) #4278
  • [d1ba82af1c] - test: fix test-domain-exit-dispose-again (Julien Gilli) #3991

Trying not to include non-security and non-build changes in this release to minimise impact to users (well, minimise their perceived impact at least).

rvagg and others added 5 commits February 8, 2016 23:34
* Include reference to CVE-2015-8027
* Fix "socket may no longer have a socket" reference
* Expand on non-existent parser causing the error
* Clarify that CVE-2015-3194 affects TLS servers using _client
  certificate authentication_

PR-URL: #4154
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Backport the tools/install.py changes from 628a3ab that were missed
when 6fb0b92 backported the corresponding changes to the Makefile to
build the headers only archive.

PR-URL: #4149
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
PR-URL: #4894
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This replaces all sources of openssl-1.0.1r.tar.gz into
deps/openssl/openssl

PR-URL: #4967
Reviewed-By: Ben Noordhuis <[email protected]>

deps: copy all openssl header files to include dir

All symlink files in `deps/openssl/openssl/include/openssl/`
are removed and replaced with real header files to avoid
issues on Windows. Two files of opensslconf.h in crypto and
include dir are replaced to refer config/opensslconf.h.

PR-URL: #4967
Reviewed-By: Ben Noordhuis <[email protected]>

deps: separate sha256/sha512-x86_64.pl for openssl

sha256-x86_64.pl does not exist in the origin openssl distribution. It
was copied from sha512-x86_64.pl and both sha256/sha512 scripts were
modified so as to generates only one asm file specified as its key
hash length.

PR: #9451
PR-URL: nodejs/node-v0.x-archive#9451
Reviewed-By: Julien Gilli <[email protected]>

deps: fix openssl assembly error on ia32 win32

`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

PR: #9451
PR-URL: nodejs/node-v0.x-archive#9451
Reviewed-By: Julien Gilli <[email protected]>

openssl: fix keypress requirement in apps on win32

reapply b910613

PR: #9451
PR-URL: nodejs/node-v0.x-archive#9451
Reviewed-By: Julien Gilli <[email protected]>

deps: add -no_rand_screen to openssl s_client

In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

(cherry picked from commit 9f0f7c38e6df975dd39735d0e9ef968076369c74)

Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node-v0.x-archive#25368
Security Update

Notable items:
@mscdex mscdex added meta Issues and PRs related to the general management of the project. v0.12 labels Feb 8, 2016
@bnoordhuis
Copy link
Member

Still needs "Notable items" filled out for OpenSSL.

  • TLS clients now reject DH handshakes with parameters shorter than 1024 bits.

We already set SSL_OP_SINGLE_DH_USE and we're not vulnerable to CVE-2015-3197 ("SSLv2 doesn't block disabled ciphers") unless --enable-ssl2 is specified on the command line (which no one should do, ever.)

@rvagg
Copy link
Member Author

rvagg commented Feb 9, 2016

finished off in node-private and released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants