deps: update undici to 6.2.1 #51278

nodejs-github-bot · 2023-12-24T09:06:50Z

This is an automated update of undici to 6.2.1.

targos · 2023-12-24T09:16:29Z

Refs: #51108

Breaking change: The body stream will now be a byte stream/support byob mode.

nodejs-github-bot · 2023-12-24T09:23:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56511/

nodejs-github-bot · 2023-12-24T15:12:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56514/

mhdawson

rubber stand LGTM

nodejs-github-bot · 2024-01-02T22:31:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56638/

mcollina · 2024-01-04T17:12:51Z

@KhafraDev can you please reference the change in undici that made this a semver-major? ~~As far as I’m aware, this was not tagged accordingly in undici. Between v5 and v6, there was only one breaking change: dropping old Node.js version.~~

KhafraDev · 2024-01-04T17:14:29Z

@mcollina nodejs/undici#2482

mcollina · 2024-01-04T17:16:13Z

Found it, thanks!

mcollina · 2024-01-04T17:17:16Z

Can you please articulate in the undici PR body what's the breaking change is? There is very little context on it.

marco-ippolito · 2024-01-04T17:21:41Z

3 commits for the same version, thats weird, the script should have ignored them, also there is a typo (note 6.2.1.) in the pr description created by the bot that makes me think there is a bug in the update script. I unfortunaly cannot reproduce locally.

KhafraDev · 2024-01-04T17:34:44Z

the main difference was support for byob mode/byte streams, but adding range support to blob urls could break people unexpectedly too

mcollina · 2024-01-05T08:23:48Z

Could you make an example of code that would run on v5 and would not run anymore on v6?
From what I'm reading, this is a feature addition.

KhafraDev · 2024-01-05T15:12:02Z

the following would throw an error in v5:

const r = await fetch('https://www.google.com')
r.body.getReader({ mode: 'byob' })

When fetch was first implemented, streams weren't byob (it's a relatively new change to the spec). I wouldn't call it a bug fix because we were handling it correctly, until the spec changed.

Here's another example, even though it's likely less impactful:

const blob = new Blob(['hello world'])
const url = URL.createObjectURL(blob)

const r = await fetch(url, {
  headers: {
    range: 'bytes=0-5'
  }
})

console.log(await r.text())
// in v5 -> "hello world"
// in v6 -> "hello"

targos · 2024-01-05T15:14:55Z

First example is typically considered semver-minor.
Second example looks more like a bug fix.

panva · 2024-01-05T15:17:29Z

This begs the question how are bugfixes and security fixes going to trickle down to existing release lines? Are there still going to be v5.x undici releases to accomodate bug fixes, security fixes? Is the github action update script ready to pull those undici v5.x updates into v18/20/21-staging branches?

richardlau · 2024-01-05T15:19:08Z

Is the github action update script ready to pull those undici v5.x updates into v18/20/21-staging branches?

AFAIK the update script running on GitHub Actions only runs for main.

panva · 2024-01-05T15:21:49Z

Is the github action update script ready to pull those undici v5.x updates into v18/20/21-staging branches?

AFAIK the update script running on GitHub Actions only runs for main.

So with this update as semver-major the future v6.x PRs should be marked as dont-land-on-* as to not cause a headache for releasers until v6.x is in the latest release line.

I guess the implications of bumping major on undici as major on Node are giving me a headache. I think undici major changes should be getting accumulated (or not released as "latest") until right before the major version bump of nodejs so that bugfixes can flow into node's regular release lines.

mcollina · 2024-01-05T15:27:29Z

I concur with @targos, those are not majors.

(fetch has done major changes, but those do not look like it).

mcollina · 2024-01-07T10:09:53Z

Adding a feature or fixing a bug is not a breaking change. If a new version of undici removed support for byob streams, then that would be a breaking change.

nodejs-github-bot · 2024-01-07T10:10:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56703/

PR-URL: #51278 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

targos · 2024-01-07T14:15:25Z

Landed in 05f8172

KhafraDev · 2024-01-08T03:11:22Z

Adding a feature or fixing a bug is not a breaking change. If a new version of undici removed support for byob streams, then that would be a breaking change.

I think this should be clarified somewhere, or an accurate definition of "stable" be listed in the node docs.

The breaking changes I listed aren't bug fixes; there wasn't any wrong with it, other than being outdated. When written, undici made the correct assumptions according to the spec. There are bug fixes that I didn't mention for this reason.

While I understand adding a feature isn't a breaking change, these changes aren't adding anything - they're changing the preexisting behavior of the code. For example, blob url parsing existed in undici 5, but we didn't check the range header. Code that is written the exact same between these 2 versions behaves differently. Same with the stream change, although to a lesser extent.

PR-URL: nodejs#51278 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

PR-URL: #51278 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: TODO

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492 doc: * update release gpg keyserver (marco-ippolito) nodejs#52257 * add release key for marco-ippolito (marco-ippolito) nodejs#52257 * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618 fs: * add stacktrace to fs/promises (翠 / green) nodejs#49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927 watch: * mark as stable (Moshe Atlow) nodejs#52074 PR-URL: nodejs#52793

deps: update undici to 6.2.1

5c7a8fa

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 24, 2023

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Dec 24, 2023

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2023

marco-ippolito approved these changes Dec 25, 2023

View reviewed changes

deps: update undici to 6.2.1

171f648

mhdawson approved these changes Jan 2, 2024

View reviewed changes

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2024

deps: update undici to 6.2.1

f5407b7

mcollina removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 5, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2024

targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 7, 2024

targos pushed a commit that referenced this pull request Jan 7, 2024

deps: update undici to 6.2.1

05f8172

PR-URL: #51278 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

targos closed this Jan 7, 2024

targos deleted the actions/tools-update-undici branch January 7, 2024 14:15

targos removed the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 7, 2024

targos mentioned this pull request Feb 15, 2024

[v21.x backport] deps: update undici to 6.6.2 #51768

Closed

targos added the backport-open-v21.x label Feb 15, 2024

targos added backported-to-v21.x and removed backport-open-v21.x labels Mar 1, 2024

RafaelGSS mentioned this pull request Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

marco-ippolito pushed a commit that referenced this pull request May 2, 2024

deps: update undici to 6.2.1

f1b7bda

PR-URL: #51278 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Filip Skokan <[email protected]>

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update undici to 6.2.1 #51278

deps: update undici to 6.2.1 #51278

nodejs-github-bot commented Dec 24, 2023

targos commented Dec 24, 2023

nodejs-github-bot commented Dec 24, 2023

nodejs-github-bot commented Dec 24, 2023

mhdawson left a comment

nodejs-github-bot commented Jan 2, 2024

mcollina commented Jan 4, 2024 •

edited

Loading

KhafraDev commented Jan 4, 2024

mcollina commented Jan 4, 2024

mcollina commented Jan 4, 2024 •

edited

Loading

marco-ippolito commented Jan 4, 2024 •

edited

Loading

KhafraDev commented Jan 4, 2024

mcollina commented Jan 5, 2024

KhafraDev commented Jan 5, 2024

targos commented Jan 5, 2024

panva commented Jan 5, 2024

richardlau commented Jan 5, 2024

panva commented Jan 5, 2024 •

edited

Loading

mcollina commented Jan 5, 2024

mcollina commented Jan 7, 2024

nodejs-github-bot commented Jan 7, 2024

targos commented Jan 7, 2024

KhafraDev commented Jan 8, 2024

deps: update undici to 6.2.1 #51278

deps: update undici to 6.2.1 #51278

Conversation

nodejs-github-bot commented Dec 24, 2023

targos commented Dec 24, 2023

nodejs-github-bot commented Dec 24, 2023

nodejs-github-bot commented Dec 24, 2023

mhdawson left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jan 2, 2024

mcollina commented Jan 4, 2024 • edited Loading

KhafraDev commented Jan 4, 2024

mcollina commented Jan 4, 2024

mcollina commented Jan 4, 2024 • edited Loading

marco-ippolito commented Jan 4, 2024 • edited Loading

KhafraDev commented Jan 4, 2024

mcollina commented Jan 5, 2024

KhafraDev commented Jan 5, 2024

targos commented Jan 5, 2024

panva commented Jan 5, 2024

richardlau commented Jan 5, 2024

panva commented Jan 5, 2024 • edited Loading

mcollina commented Jan 5, 2024

mcollina commented Jan 7, 2024

nodejs-github-bot commented Jan 7, 2024

targos commented Jan 7, 2024

KhafraDev commented Jan 8, 2024

mcollina commented Jan 4, 2024 •

edited

Loading

mcollina commented Jan 4, 2024 •

edited

Loading

marco-ippolito commented Jan 4, 2024 •

edited

Loading

panva commented Jan 5, 2024 •

edited

Loading