Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: move NAPI_EXPERIMENTAL definition to gyp file #51254

Merged
merged 1 commit into from
Jan 10, 2024
Merged

node-api: move NAPI_EXPERIMENTAL definition to gyp file #51254

merged 1 commit into from
Jan 10, 2024

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Dec 22, 2023
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56462/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56470/

vmoroz
vmoroz approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 31, 2023
@mhdawson mhdawson added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 2, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56636/

mhdawson
mhdawson approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit be755e0 into nodejs:main Jan 10, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in be755e0

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@gabrielschulhof @marco-ippolito
node-api: move NAPI_EXPERIMENTAL definition to gyp file
70a0b43 
PR-URL: nodejs#51254
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@gabrielschulhof @Medhansh404
node-api: move NAPI_EXPERIMENTAL definition to gyp file
8993291 
PR-URL: nodejs#51254
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
@gabrielschulhof @targos
node-api: move NAPI_EXPERIMENTAL definition to gyp file
5b94ff4 
PR-URL: #51254
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
toyobayashi added a commit to toyobayashi/emnapi that referenced this pull request Mar 9, 2024
@toyobayashi
test: move NAPI_EXPERIMENTAL definition to cmake file (nodejs/node#51254
b53831a 
)
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@gabrielschulhof @richardlau
node-api: move NAPI_EXPERIMENTAL definition to gyp file
5fe33ba 
PR-URL: #51254
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@gabrielschulhof @richardlau
node-api: move NAPI_EXPERIMENTAL definition to gyp file
0fb9843 
PR-URL: #51254
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@vmoroz vmoroz vmoroz approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@daeyeon daeyeon daeyeon approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@gabrielschulhof @nodejs-github-bot @apapirovski @vmoroz @lpinca @richardlau @daeyeon @legendecas @mhdawson @debadree25