tools: lint for empty character classes in regex #5115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation.
|
LGTM. I checked that it doesn't reject |
|
LGTM |
|
(What does an empty class even do?) LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Feb 7, 2016
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: #5115 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 478c682 |
Never match, basically. |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: #5115 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 9, 2016
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: #5115 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: #5115 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: #5115 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: #5115 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Enable linting rule to forbid empty character classes in regular expressions. See http://eslint.org/docs/rules/no-empty-character-class Organize "Possible Error" rules in .eslintrc in alphabetical order to match eslint documentation. PR-URL: nodejs#5115 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable linting rule to forbid empty character classes in regular
expressions. See http://eslint.org/docs/rules/no-empty-character-class
Organize "Possible Error" rules in .eslintrc in alphabetical order to
match eslint documentation.