Updated packages.md and added --experimental-detect-module flag #51089
Conversation
added --experimental-detect-module flag in the docs.
|
Review requested:
|
|
It feels wrong to duplicate what we have in |
@GeoffreyBooth I understand. But I did this after I asked here #51057 to fix the issue mentioned there. I'm new to github. My apology if any trouble caused. |
|
@shubherthi-mitra you didn’t do anything wrong, thank you for the contribution! My question was more for @nodejs/loaders, if we want to repeat the info here like you’ve done in this PR or if we’d rather do it differently, such as by just mentioning the flag’s existence and linking to its primary documentation. |
I think this (smaller surface area to update, less chance of divergence). |
|
I think what we want is to modify the paragraph added in https://github.com/nodejs/node/pull/50096/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63 to add a mention of the flag (and a link to |
Mentioned --experimental-detect-module flag and added its reference to cli.md
I did as you have said. Please check it. |
--experimental-detect-module flag and link to cli.md added.
Mentioned --experimental-defect-module flag in doc and added ref link to cli.md
Simplified the paragraph under the heading ###Determining module system, mentioning --experimental-detect-module flag and reference to cli.md
|
Landed in 37ba7a3, thanks for the contribution 🎉 |
PR-URL: #51089 Fixes: #51057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #51089 Fixes: #51057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
added --experimental-detect-module flag in the docs to resolve #51057
Fixes: #51057