Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: remove workaround for esm package #50907

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fs: remove workaround for esm package #50907

merged 1 commit into from
Nov 27, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 25, 2023 •
edited
Loading

Removes a TODO left by @ronag

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 25, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55921/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55922/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit 95b1989 into nodejs:main Nov 27, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 95b1989

targos pushed a commit that referenced this pull request Dec 4, 2023
@anonrig @targos
fs: remove workaround for esm package
c1ee506 
PR-URL: #50907
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
This was referenced Dec 4, 2023
Merged
Closed
@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Dec 7, 2023
@ronag
Copy link
Member

ronag commented Dec 7, 2023

A little unsure why this was applied before standard-things/esm#821 was resolved?

@targos
Copy link
Member

targos commented Feb 15, 2024

@ronag The esm module was archived. It will never be resolved.

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@jeremymeng @marco-ippolito
Revert "fs: remove workaround for esm package"
f130a33 
This reverts commit 95b1989.

It appears that the workaround is still needed: issue #51081

Backport-PR-URL: #51390
PR-URL: #50907
Fixes: #51081
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@MoLow MoLow MoLow approved these changes

@ronag ronag ronag approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @ronag @targos @lpinca @MoLow @H4ad