-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update cares to 2bae2d56d7866defcee18455c1f2ecfef6c7663d #5090
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
/* ares_build.h. Generated from ares_build.h.in by configure. */ | ||
#ifndef __CARES_BUILD_H | ||
#define __CARES_BUILD_H | ||
|
||
|
||
/* Copyright (C) 2009 by Daniel Stenberg et al | ||
* | ||
* Permission to use, copy, modify, and distribute this software and its | ||
* documentation for any purpose and without fee is hereby granted, provided | ||
* that the above copyright notice appear in all copies and that both that | ||
* copyright notice and this permission notice appear in supporting | ||
* documentation, and that the name of M.I.T. not be used in advertising or | ||
* publicity pertaining to distribution of the software without specific, | ||
* written prior permission. M.I.T. makes no representations about the | ||
* suitability of this software for any purpose. It is provided "as is" | ||
* without express or implied warranty. | ||
*/ | ||
|
||
/* ================================================================ */ | ||
/* NOTES FOR CONFIGURE CAPABLE SYSTEMS */ | ||
/* ================================================================ */ | ||
|
||
/* | ||
* NOTE 1: | ||
* ------- | ||
* | ||
* Nothing in this file is intended to be modified or adjusted by the | ||
* c-ares library user nor by the c-ares library builder. | ||
* | ||
* If you think that something actually needs to be changed, adjusted | ||
* or fixed in this file, then, report it on the c-ares development | ||
* mailing list: http://cool.haxx.se/mailman/listinfo/c-ares/ | ||
* | ||
* This header file shall only export symbols which are 'cares' or 'CARES' | ||
* prefixed, otherwise public name space would be polluted. | ||
* | ||
* NOTE 2: | ||
* ------- | ||
* | ||
* Right now you might be staring at file ares_build.h.in or ares_build.h, | ||
* this is due to the following reason: | ||
* | ||
* On systems capable of running the configure script, the configure process | ||
* will overwrite the distributed ares_build.h file with one that is suitable | ||
* and specific to the library being configured and built, which is generated | ||
* from the ares_build.h.in template file. | ||
* | ||
*/ | ||
|
||
/* ================================================================ */ | ||
/* DEFINITION OF THESE SYMBOLS SHALL NOT TAKE PLACE ANYWHERE ELSE */ | ||
/* ================================================================ */ | ||
|
||
#ifdef CARES_SIZEOF_LONG | ||
# error "CARES_SIZEOF_LONG shall not be defined except in ares_build.h" | ||
Error Compilation_aborted_CARES_SIZEOF_LONG_already_defined | ||
#endif | ||
|
||
#ifdef CARES_TYPEOF_ARES_SOCKLEN_T | ||
# error "CARES_TYPEOF_ARES_SOCKLEN_T shall not be defined except in ares_build.h" | ||
Error Compilation_aborted_CARES_TYPEOF_ARES_SOCKLEN_T_already_defined | ||
#endif | ||
|
||
#ifdef CARES_SIZEOF_ARES_SOCKLEN_T | ||
# error "CARES_SIZEOF_ARES_SOCKLEN_T shall not be defined except in ares_build.h" | ||
Error Compilation_aborted_CARES_SIZEOF_ARES_SOCKLEN_T_already_defined | ||
#endif | ||
|
||
/* ================================================================ */ | ||
/* EXTERNAL INTERFACE SETTINGS FOR CONFIGURE CAPABLE SYSTEMS ONLY */ | ||
/* ================================================================ */ | ||
|
||
/* Configure process defines this to 1 when it finds out that system */ | ||
/* header file ws2tcpip.h must be included by the external interface. */ | ||
|
||
#ifdef WIN32 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this should be _WIN32 instead? I see the CI failed because on the include in line 96, which wouldn't happen if we entered through here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did this change after failure, and now it seems to be fixed. |
||
# define CARES_PULL_WS2TCPIP_H 1 | ||
#else | ||
# define CARES_PULL_SYS_TYPES_H 1 | ||
# define CARES_PULL_SYS_SOCKET_H 1 | ||
#endif | ||
|
||
/* #undef CARES_PULL_WS2TCPIP_H */ | ||
#ifdef CARES_PULL_WS2TCPIP_H | ||
# ifndef WIN32_LEAN_AND_MEAN | ||
# define WIN32_LEAN_AND_MEAN | ||
# endif | ||
# include <windows.h> | ||
# include <winsock2.h> | ||
# include <ws2tcpip.h> | ||
#endif | ||
|
||
/* Configure process defines this to 1 when it finds out that system */ | ||
/* header file sys/types.h must be included by the external interface. */ | ||
#ifdef CARES_PULL_SYS_TYPES_H | ||
# include <sys/types.h> | ||
#endif | ||
|
||
/* Configure process defines this to 1 when it finds out that system */ | ||
/* header file sys/socket.h must be included by the external interface. */ | ||
#ifdef CARES_PULL_SYS_SOCKET_H | ||
# include <sys/socket.h> | ||
#endif | ||
|
||
/* The size of `long', as computed by sizeof. */ | ||
/* #undef CARES_SIZEOF_LONG */ | ||
|
||
/* Integral data type used for ares_socklen_t. */ | ||
#define CARES_TYPEOF_ARES_SOCKLEN_T socklen_t | ||
|
||
/* The size of `ares_socklen_t', as computed by sizeof. */ | ||
#define CARES_SIZEOF_ARES_SOCKLEN_T 4 | ||
|
||
/* Data type definition of ares_socklen_t. */ | ||
typedef CARES_TYPEOF_ARES_SOCKLEN_T ares_socklen_t; | ||
|
||
#endif /* __CARES_BUILD_H */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file be defined in the GYP file too? Also, ares_rules.h was moved: https://github.com/nodejs/node/blob/master/deps/cares/cares.gyp#L82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like
ares_rules.h
can be moved much. It is included fromares.h
. I'm not sure about moving build stuff to GYP too. Current directory structure seems to be easier to update.