Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: get rid of unnecessary eslint-skip comments #50829

Merged
merged 2 commits into from
Nov 22, 2023
Merged

doc: get rid of unnecessary eslint-skip comments #50829

merged 2 commits into from
Nov 22, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 20, 2023

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 20, 2023
@aduh95 aduh95 mentioned this pull request Nov 20, 2023
Merged
4 tasks
Ethan-Arrowood
Ethan-Arrowood requested changes Nov 20, 2023
View reviewed changes
doc/api/querystring.md Outdated Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5dd7ba6 into nodejs:main Nov 22, 2023
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5dd7ba6

targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
doc: get rid of unnecessary eslint-skip comments
cd54549 
PR-URL: #50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@aduh95 @martenrichter
doc: get rid of unnecessary eslint-skip comments
9cdef98 
PR-URL: nodejs#50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@aduh95
doc: get rid of unnecessary eslint-skip comments
19ac425 
PR-URL: nodejs#50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@aduh95 @RafaelGSS
doc: get rid of unnecessary eslint-skip comments
08c3b0a 
PR-URL: #50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@aduh95 @RafaelGSS
doc: get rid of unnecessary eslint-skip comments
d69d3ec 
PR-URL: #50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@aduh95 @UlisesGascon
doc: get rid of unnecessary eslint-skip comments
7a6e3b9 
PR-URL: #50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@aduh95 @UlisesGascon
doc: get rid of unnecessary eslint-skip comments
84a6658 
PR-URL: #50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@aduh95 @UlisesGascon
doc: get rid of unnecessary eslint-skip comments
8070f6f 
PR-URL: #50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@aduh95 @UlisesGascon
doc: get rid of unnecessary eslint-skip comments
b3d015d 
PR-URL: #50829
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aduh95 @nodejs-github-bot @ShogunPanda @lpinca @anonrig @tniessen @UlisesGascon @Ethan-Arrowood @marco-ippolito